On 09/21/15 at 04:03pm, Eric Dumazet wrote: > What I said is : > > In @head you already have the correct nulls value, from hash table. > > You do not need to recompute this value, and/or test if hash table chain > is empty. > > If hash bucket is empty, it contains the appropriate NULLS value. > > If you are paranoiac add this debugging check : > > if (rht_is_a_nulls(head)) > BUG_ON(head != (struct rhash_head *)rht_marker(ht, new_hash)); > > > Therefore, simply fix the bug and unnecessary code with :
You are absolutely right Eric. Do you want to revise your patch Dmitry? Eric's proposed fix absolutely the best way to fix this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
