On 9/19/15, 7:21 PM, Scott Feldman wrote:
Yes, your switch driver is in user-space so you have to use NTF_USE to
refresh the entry since you cannot use the kernel driver model to
call_switchdev_notifiers(SWITCHDEV_FDB_ADD, ...). Consequently, your
entries are not marked with NTF_EXT_LEARNED, so this patch is a no-op
for you. You can continue to use the bridge driver to age out your
entries.
yes, correct. I was not really saying this because it will cause us any
problems.
I was trying to say this for switchdev in general.
I'd rather someone add that knob when it's actually needed. When the
first in-kernel switchdev driver that wants to use the bridge driver's
ageing function, then we can make that adjustment.
I was suggesting the other way around. Keep the default to what is in
the kernel today and the first in-kernel switchdev driver that wants to age,
should introduce the ability to not age in the bridge driver (Rocker
will continue to work as it does today). Because, I am only concerned
that rocker may end up being the only device that uses the default
behavior introduced by this patch. And every real hardware uses the
bridge driver to age (because there are no in kernel examples today). I
am curious to know who else is using hardware ageing today.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
