From: Ursula Braun <ubr...@linux.vnet.ibm.com>
Date: Tue, 15 Sep 2015 12:32:17 +0200

> +int qeth_send_setassparms(struct qeth_card *, struct qeth_cmd_buffer *, 
> __u16,
> +     long,
> +     int (*reply_cb)(struct qeth_card *, struct qeth_reply *, unsigned long),
> +     void *);

Function declarations and definitions that span multiple lines must begin
the second and subsequent lines precisely at the column right after the
openning parenthesis of the declaration/definition.

Indenting those lines just by a plain TAB character is not correct.

> +static int qeth_setassparms_cb(struct qeth_card *card,
> +                     struct qeth_reply *reply, unsigned long data)

Likewise.

> +static struct qeth_cmd_buffer *qeth_get_setassparms_cmd(
> +     struct qeth_card *card, enum qeth_ipa_funcs ipa_func, __u16 cmd_code,
> +     __u16 len, enum qeth_prot_versions prot)

Likewise.

> +int qeth_send_setassparms(struct qeth_card *card,
> +     struct qeth_cmd_buffer *iob, __u16 len, long data,
> +     int (*reply_cb)(struct qeth_card *, struct qeth_reply *,
> +             unsigned long),
> +     void *reply_param)

Likewise.

And so on and so forth.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to