On 09/02/15 at 01:22pm, David Ahern wrote: > On 9/2/15 1:12 PM, Thomas Graf wrote: > >On 09/02/15 at 12:03pm, David Ahern wrote: > >>Add support for 'ip [-6] route get table X' where the user wants to > >>force the FIB lookup from a given table. > >> > >>Signed-off-by: David Ahern <d...@cumulusnetworks.com> > > > >Will you use this outside of 'ip route get' as well? If so, how? I'm > >asking because you propose to add the check and new behaviour to bypass > >the routing rules to the routing fastpath, wouldn't it be better to > >handle this in inet_rtm_getroute()? > > > > The way IPv6 code is structured it seemed more appropriate to pass in a > table id as part of the flow. I made IPv4 consistent with that approach.
The question is: Are you planning to use the new table_id in flowi in the actual datapath as well? It seems entirely wrong to add weight to the fast path for a control plane feature. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
