> On Sep 1, 2015, at 11:50 AM, David Ahern <d...@cumulusnetworks.com> wrote:
>
> A number of VRF patches used 'int' for table id. It should be u32 to be
> consistent with the rest of the stack.
>
> Fixes:
> 4e3c89920cd3a ("net: Introduce VRF related flags and helpers")
> 15be405eb2ea9 ("net: Add inet_addr lookup by table")
> 30bbaa1950055 ("net: Fix up inet_addr_type checks")
> 021dd3b8a142d ("net: Add routes to the table associated with the device")
> dc028da54ed35 ("inet: Move VRF table lookup to inlined function")
> f6d3c19274c74 ("net: FIB tracepoints")
>
> Signed-off-by: David Ahern <d...@cumulusnetworks.com>
> ---
> v2
> - update tracepoint as well (thanks, Nikolay)
>
> include/net/route.h | 2 +-
> include/net/vrf.h | 24 ++++++++++++------------
> include/trace/events/fib.h | 4 ++--
> net/ipv4/af_inet.c | 2 +-
> net/ipv4/fib_frontend.c | 10 +++++-----
> net/ipv4/fib_semantics.c | 2 +-
> 6 files changed, 22 insertions(+), 22 deletions(-)
<<snip>>
> diff --git a/include/trace/events/fib.h b/include/trace/events/fib.h
> index acd1d22571a2..e9cea16d1515 100644
> --- a/include/trace/events/fib.h
> +++ b/include/trace/events/fib.h
> @@ -11,12 +11,12 @@
>
> TRACE_EVENT(fib_table_lookup,
>
> - TP_PROTO(int tb_id, const struct flowi4 *flp),
> + TP_PROTO(u32 tb_id, const struct flowi4 *flp),
>
> TP_ARGS(tb_id, flp),
>
> TP_STRUCT__entry(
> - __field( int, tb_id )
> + __field( u32, tb_id )
> __field( int, oif )
> __field( int, iif )
> __field( __u8, tos )
I think you should update the TP_printk below as well, it’s treating it as a
signed integer. :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
