On September 1, 2015 8:18:29 PM GMT+02:00, Sergei Shtylyov
<sergei.shtyl...@cogentembedded.com> wrote:
>Hello.
>
>On 09/01/2015 06:43 PM, Ahmed Amamou wrote:
>
>> Signed-off-by: Ahmed Amamou <ah...@gandi.net>
>> ---
>> net/bridge/rbr.c | 14 ++++++++++++++
>> net/bridge/rbr_private.h | 2 ++
>> net/bridge/rbr_rtnetlink.c | 6 ++++++
>> 3 files changed, 22 insertions(+)
>>
>> diff --git a/net/bridge/rbr.c b/net/bridge/rbr.c
>> index c554743..31e72ef 100644
>> --- a/net/bridge/rbr.c
>> +++ b/net/bridge/rbr.c
>> @@ -69,3 +69,17 @@ void br_trill_set_enabled(struct net_bridge *br,
>unsigned long val)
>> br_trill_stop(br);
>> }
>> }
>> +
>> +int set_treeroot(struct rbr *rbr, uint16_t treeroot)
>> +{
>> + if (unlikely(!VALID_NICK(treeroot))) {
>> + pr_warn_ratelimited
>> + ("rbr_set_treeroot: given tree root not valid\n");
>> + goto set_tree_root_fail;
>
> This seems a bit stupid. Why not *return* directly?
Indeed, we will fix it.
>
>> + }
>> + if (rbr->treeroot != treeroot)
>> + rbr->treeroot = treeroot;
>> + return 0;
>> + set_tree_root_fail:
>> + return -ENOENT;
>> +}
>[...]
>
>MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
