On 31/08/15 05:25, Madalin-Cristian Bucur wrote: >> -----Original Message----- >> From: netdev-ow...@vger.kernel.org [mailto:netdev- >> Subject: Re: [net-next:master 1512/1524] net/ipv4/af_inet.c:1486:26: error: >> 'offt' undeclared >> >> From: kbuild test robot <fengguang...@intel.com> >> Date: Mon, 31 Aug 2015 13:06:10 +0800 >> >>> net/ipv4/af_inet.c: In function 'snmp_get_cpu_field64': >>>>> net/ipv4/af_inet.c:1486:26: error: 'offt' undeclared (first use in this >> function) >>> v = *(((u64 *)bhptr) + offt); >>> ^ >>> net/ipv4/af_inet.c:1486:26: note: each undeclared identifier is reported >> only once for each function it appears in >>> net/ipv4/af_inet.c: In function 'snmp_fold_field64': >>>>> net/ipv4/af_inet.c:1499:39: error: 'offct' undeclared (first use in this >> function) >>> res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset); >>> ^ >>>>> net/ipv4/af_inet.c:1499:10: error: too many arguments to function >> 'snmp_get_cpu_field' >>> res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset); >>> ^ >>> net/ipv4/af_inet.c:1455:5: note: declared here >>> u64 snmp_get_cpu_field(void __percpu *mib, int cpu, int offt) >>> ^ >>> net/ipv4/af_inet.c:1499: confused by earlier errors, bailing out >> >> Thanks, this should fix it: >> >> ==================== >> [PATCH] ipv4: Fix 32-bit build. >> >> net/ipv4/af_inet.c: In function 'snmp_get_cpu_field64': >>>> net/ipv4/af_inet.c:1486:26: error: 'offt' undeclared (first use in this >> function) >> v = *(((u64 *)bhptr) + offt); >> ^ >> net/ipv4/af_inet.c:1486:26: note: each undeclared identifier is reported >> only once for each function it appears in >> net/ipv4/af_inet.c: In function 'snmp_fold_field64': >>>> net/ipv4/af_inet.c:1499:39: error: 'offct' undeclared (first use in this >> function) >> res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset); >> ^ >>>> net/ipv4/af_inet.c:1499:10: error: too many arguments to function >> 'snmp_get_cpu_field' >> res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset); >> ^ >> net/ipv4/af_inet.c:1455:5: note: declared here >> u64 snmp_get_cpu_field(void __percpu *mib, int cpu, int offt) >> ^ >> >> Reported-by: kbuild test robot <fengguang...@intel.com> >> Signed-off-by: David S. Miller <da...@davemloft.net> >> --- >> net/ipv4/af_inet.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c >> index 0c69c0b..c2d0ebc 100644 >> --- a/net/ipv4/af_inet.c >> +++ b/net/ipv4/af_inet.c >> @@ -1471,7 +1471,7 @@ EXPORT_SYMBOL_GPL(snmp_fold_field); >> >> #if BITS_PER_LONG==32 >> >> -u64 snmp_get_cpu_field64(void __percpu *mib, int cpu, int offct, >> +u64 snmp_get_cpu_field64(void __percpu *mib, int cpu, int offt, >> size_t syncp_offset) >> { >> void *bhptr; >> @@ -1496,7 +1496,7 @@ u64 snmp_fold_field64(void __percpu *mib, int >> offt, size_t syncp_offset) >> int cpu; >> >> for_each_possible_cpu(cpu) { >> - res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset); >> + res += snmp_get_cpu_field(mib, cpu, offt, syncp_offset); >> } >> return res; >> } >> -- >> 2.1.0 >> >> -- > > Hi, > > shouldn't that be snmp_get_cpu_field64() ? > > - res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset); > + res += snmp_get_cpu_field64(mib, cpu, offt, syncp_offset);
Yes, that fixes the build for me as well and sounds like the intent. -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
