From: Daniel Borkmann <[email protected]> Date: Thu, 27 Aug 2015 10:11:37 +0200
> For classifiers getting invoked via tc_classify(), we always need an > extra function call into tc_classify_compat(), as both are being > exported as symbols and tc_classify() itself doesn't do much except > handling of reclassifications when tp->classify() returned with > TC_ACT_RECLASSIFY. > > CBQ and ATM are the only qdiscs that directly call into tc_classify_compat(), > all others use tc_classify(). When tc actions are being configured > out in the kernel, tc_classify() effectively does nothing besides > delegating. > > We could spare this layer and consolidate both functions. Artificial > pktgen micro benchmark on single CPU constantly pushing skbs directly > into the netif_receive_skb() path with a dummy classifier on ingress > qdisc attached, improves slightly from 22.3Mpps to 23.1Mpps. > > Signed-off-by: Daniel Borkmann <[email protected]> > Acked-by: Alexei Starovoitov <[email protected]> > --- > v1 -> v2: > - Addressed minor style nits found by Alexei. Sorry, I applied v1 before seeing this :-/ If you could post a relative patch fixing the style issues, I'd appreciate it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
