From: Jiri Pirko <j...@mellanox.com>

When transmit fails, it is an error, not a warning.
Do not warn when timeout happens as that is handled by a counter.

Signed-off-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Ido Schimmel <ido...@mellanox.com>
Signed-off-by: Elad Raz <el...@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c 
b/drivers/net/ethernet/mellanox/mlxsw/core.c
index 6ee3f45..dfafb83 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -382,8 +382,8 @@ static int __mlxsw_emad_transmit(struct mlxsw_core 
*mlxsw_core,
 
        err = mlxsw_core_skb_transmit(mlxsw_core->driver_priv, skb, tx_info);
        if (err) {
-               dev_warn(mlxsw_core->bus_info->dev, "Failed to transmit EMAD 
(tid=%llx)\n",
-                        mlxsw_core->emad.tid);
+               dev_err(mlxsw_core->bus_info->dev, "Failed to transmit EMAD 
(tid=%llx)\n",
+                       mlxsw_core->emad.tid);
                dev_kfree_skb(skb);
                return err;
        }
@@ -393,8 +393,8 @@ static int __mlxsw_emad_transmit(struct mlxsw_core 
*mlxsw_core,
                                 !(mlxsw_core->emad.trans_active),
                                 msecs_to_jiffies(MLXSW_EMAD_TIMEOUT_MS));
        if (!ret) {
-               dev_warn(mlxsw_core->bus_info->dev, "EMAD timed-out 
(tid=%llx)\n",
-                        mlxsw_core->emad.tid);
+               dev_dbg(mlxsw_core->bus_info->dev, "EMAD timed-out 
(tid=%llx)\n",
+                       mlxsw_core->emad.tid);
                mlxsw_core->emad.trans_active = false;
                mlxsw_core->emad.stats.timeouts++;
                return -EIO;
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to