Tue, Aug 18, 2015 at 09:21:15AM CEST, sfel...@gmail.com wrote: >On Mon, Aug 17, 2015 at 11:48 PM, Jiri Pirko <j...@resnulli.us> wrote: >> Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote: >>>On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko <j...@resnulli.us> wrote: >>>> Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: >>>>>From: Scott Feldman <sfel...@gmail.com> >>>> >>>> <snip> >>>> >>>>>+ rocker->dbg_dir = debugfs_create_dir(dbg_dir_name, rocker_dbg_root); >>>>>+ if (!rocker->dbg_dir) >>>> >>>> You still check the retval here and >>> >>>It's OK. See include/linux/debugfs.h when CONFIG_DEBUG_FS=n. >>>debugfs_create_dir() returns ERR_PTR(-ENODEV), which is !NULL. >> >> Does not make sense to check it for NULL then. It is never NULL... > >It can be NULL when CONFIG_DEBUG_FS=y.
You are right, this inconsistency looks odd to me though. Anyway, Acked-by: Jiri Pirko <j...@resnulli.us> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
