On Sun, Aug 09, 2015 at 03:39:25PM +0300, Sergei Shtylyov wrote: > Hello. > > On 8/9/2015 4:29 AM, Andrew Lunn wrote: > > >When using a cluster of switches, some topologies will have an MDIO > >bus per switch, not one for the whole cluster. Allow this to be > >represented in the device tree, by adding an optional mii-bus property > >at the switch level. > > >Signed-off-by: Andrew Lunn <and...@lunn.ch> > >Reviewed-by: Florian Fainelli <f.faine...@gmail.com> > >--- > > > >v2: Fix documentation, which placed the properties documentation in > > the wrong place. > >--- > > Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 +++++ > > net/dsa/dsa.c | 12 +++++++++++- > > 2 files changed, 16 insertions(+), 1 deletion(-) > > >diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt > >b/Documentation/devicetree/bindings/net/dsa/dsa.txt > >index f0b4cd72411d..fc06f4a7c788 100644 > >--- a/Documentation/devicetree/bindings/net/dsa/dsa.txt > >+++ b/Documentation/devicetree/bindings/net/dsa/dsa.txt > >@@ -32,6 +32,10 @@ A switch child node has the following optional property: > > the presence and/or size of a connected EEPROM, > > otherwise optional. > > > >+- mii-bus : Should be a phandle to a valid MDIO bus device node. > > Why not call it "mdio-bus"?
Hi Sergei What you cannot see in this hunk, but can in the file is: Marvell Distributed Switch Architecture Device Tree Bindings ------------------------------------------------------------ Required properties: - compatible : Should be "marvell,dsa" - #address-cells : Must be 2, first cell is the address on the MDIO bus and second cell is the address in the switch tree. Second cell is used only when cascading/chaining. - #size-cells : Must be 0 - dsa,ethernet : Should be a phandle to a valid Ethernet device node - dsa,mii-bus : Should be a phandle to a valid MDIO bus device node The optional mii-bus properties i'm adding should be used in preference to this global one, for this switch. Keeping the names the same makes sense. But i did drop the dsa prefix to indicate it is local, not global scope, and all the other properties at switch level do not use the dsa prefix. Andrew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html