From: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com>
Date: Tue, 28 Jul 2015 11:16:23 -0300
> The problem is not on being bigger than what we want, but on being
> smaller, as it causes read of invalid memory.
>
> Note that the struct changes on commit 7e8616d8e773 didn't affect
> sctp_setsockopt_events one but that's where this check was flipped.
>
> Fixes: 7e8616d8e773 ("[SCTP]: Update AUTH structures to match
> declarations in draft-16.")
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com>
This makes things worse.
The copy_from_user() call is bounded by optlen, so if you allow it to
be any arbitrary large value the user can write past the end of the
structure, corrupting kernel memory.
No, the test is correct, or at least necessary, as-is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
