On Wed, 2015-07-29 at 14:24 +0300, Kirill Tkhai wrote:
> commit 56b765b79 ("htb: improved accuracy at high rates")
> broke the "mpu xxx" handling.
>
> This patch restores the "mpu xxx" handling for htb:
>
> # tc class add dev eth0 classid 1:2 parent 1: htb rate 1mbit mpu 0
> # ping -f -c 1000 10.30.22.52
> rtt min/avg/max/mdev = 0.156/1.881/2.454/0.175 ms, ipg/ewma 1.908/1.925 ms
>
> # tc class change dev eth0 classid 1:2 parent 1: htb rate 1mbit mpu 1000
> # ping -f -c 1000 10.30.22.52
> rtt min/avg/max/mdev = 15.352/22.229/38.646/2.212 ms, pipe 3, ipg/ewma
> 15.999/22.609 ms
Note this mpu option was completely broken a long time ago with GSO /
TSO anyway.
Note sure we really want it in this state ?
What is your use case ?
In any case, correct fix would be in psched_l2t_ns(), otherwise you fix
htb but not the other qdisc (tbf for that matter)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
