> -----Original Message----- > From: David Miller [mailto:[email protected]] > Sent: Monday, July 27, 2015 2:35 AM > To: Bucur Madalin-Cristian-B32716 > Cc: [email protected]; [email protected]; linuxppc- > [email protected]; [email protected]; Wood Scott-B07421; > Liberman Igal-B31950; [email protected]; [email protected]; > [email protected] > Subject: Re: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds > > From: Madalin-Cristian Bucur <[email protected]> > Date: Fri, 24 Jul 2015 15:49:39 +0000 > > >> -----Original Message----- > >> From: Joe Perches [mailto:[email protected]] > >> On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote: > >> > Allow the user to tweak the refill threshold and the total number > >> > of buffers in the buffer pool. The provided values are for one CPU. > >> > >> Any value in making these module parameters instead? > > > > I expect one would (hardly ever) change these to improve some corner > > cases then use them with the new values. It may help in the tuning process > > but afterwards the bloat to the bootcmd would probably be a nuisance. > > I think these should be controlled by the existing ethtool infrastructure. > > Neither the Kconfig mechanism nor module parameters are appropriate, at > all.
The existing ethtool options are for ring based drivers (ethtool -g / -G). I would not use those as we are not using rings (they do not map well anyway). We could introduce special options for our non-ring devices but for these parameters in particular I'd just resort to defines in the code as it's improbable one would want to change them. Madalin -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
