From: David Miller <da...@davemloft.net> Sent: Monday, July 27, 2015 7:27 AM > To: Duan Fugang-B38611 > Cc: netdev@vger.kernel.org; Li Frank-B20596; step...@networkplumber.org > Subject: Re: [PATCH v1 net-next 1/1] net: fec: add stop mode request > on/off implemention > > From: Fugang Duan <b38...@freescale.com> > Date: Wed, 22 Jul 2015 18:13:43 +0800 > > > The current driver depends on platform data to implement stop mode > > request on/off that call api pdata->sleep_mode_enable(). > > > > To reduce arch platform redundancy code, since the function only set > > SOC GPR register bit to request stop mode of/off, so we can move the > > function into driver. And the specifix GPR register offset and MASK > > bit can be transferred from DTS. > > > > Signed-off-by: Fugang Duan <b38...@freescale.com> > > Doesn't this break stop mode on those devices until the DTS is updated? > > That's really unfortunate, because you're leaving all of the platform > data and implementation there, yet it's going to be unused. > > I really think you need to keep the code using the platform data bits > around until all the DTSs are updated. > > No matter what you tell me about how DTSs are updated (don't even mention > the details, I do not care) you simply cannot keep the platform data code > around and not use it. It is completely nonsensible to have code that > would properly function and properly support a feature for the device in > the kernel, yet not use it. > > Period.
Thanks for your comments. Firstly, I will send some board dts patches (and test). Secondly, the net/next tree have no platform data for stop mode because others suggest us to use dts not platform data, and there have no any boards support stop mode in net/next, so this doesn't break any boards in net/next. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
