From: Florian Fainelli <f.faine...@gmail.com> Date: Wed, 22 Jul 2015 15:11:54 -0700
> Instead of multiplying the number of checks for IS_ERR(priv->clk), > simply NULLify the 'struct clk' pointer which is something the Linux > common clock framework perfectly deals with and does early return for > each and every single clk_* API functions. > > Having every single function check for !IS_ERR(priv->clk) is both > redundant and error prone, as it turns out, we were doing it for the > main GENET clock: priv->clk, but not for the Wake-on-LAN or EEE clock, > so let's just be consistent here. > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> My understanding is that you will be posting a new version of this patch updating the cases in bcmgenet_probe() that Patri pointed out. Right? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
