On 7/15/2015 1:45 PM, Sergei Shtylyov wrote:

First, dma_sync_single_for_cpu() shouldn't have been called in the first place
(it's a streaming DMA API). dma_unmap_single() should have been called instead.
                           ^
    Oops, I meant comma here.

Second, dma_unmap_single() call after handing the buffer to napi_gro_receive()
makes little sense.

    Moreover, 'desc->dptr' may not be valid at this point...

Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>

---
The patch is against Dave Miller's 'net.git' repo.

Don't know why I missed this DMA API misuse while working on the driver. :-<

    Dave, do you want me to resend the patch with fixed up changelog?

   Oops, forgot to CC Dave. :-(

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to