Hi David, On Jul 11, 2015, at 10:08 PM, David da...@davemloft.net wrote:
> From: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > Date: Sat, 11 Jul 2015 14:36:12 -0400 (EDT) > >> In the meantime, this is really useful for development. i.e. ensuring a good >> switchdev/DSA interaction without being able to read and write directly the >> hardware VLAN table, is a bit a PITA. A dynamic debugfs looked appropriate. > > For "development" you can hack the driver, add tracepoints, or use > another mechanism anyone hacking the kernel (which by definition > someone doing "development" is doing) can do. > > I do not buy any of your arguments, and you really miss the grand > opportunity to export the knobs and values in a way which are going > to: > > 1) Be useful to users > > 2) Be usable by any similar DSA driver, not just _yours_ I hardly see how this debug interface can be made generic to other DSA drivers, since the format of hardware tables or some registers seem very specific to the switch chip. > So please stop this myopic narrow thinking when you add facilities for > development or export values. Think of the big picture and long term, > not just your personal perceived immediate needs of today. I understand. So it looks like the only reasonable solution here is to revert this support for the debugfs interface. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
