On Tue, Jul 7, 2015 at 10:25 AM, Vasily Averin <v...@virtuozzo.com> wrote: > On 07.07.2015 20:13, Cong Wang wrote: >> On Tue, Jul 7, 2015 at 8:53 AM, Vasily Averin <v...@virtuozzo.com> wrote: >>> ipmr_free_table() calls unregister_netdevice_many() inside >>> and changes net_todo_list protected by rtnl_lock >> >> Did you see any real bug? > > No, it was result of manual code review. > >> ipmr_free_table() is called in failure path, in this case there is no >> device registered yet, so unregister should be just a nop? > > However may be it's better to mark this place for future anyway?
Then add a comment there. ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html