On Mon, 29 Jun 2015 20:07:20 +0200 Pablo Neira Ayuso <[email protected]> wrote:
> On Thu, Jun 25, 2015 at 11:12:06PM -0400, Stephen Hemminger wrote: > > This fixes breakage to iproute2 build with recent kernel headers > > caused by: > > commit a263653ed798216c0069922d7b5237ca49436007 > > Author: Pablo Neira Ayuso <[email protected]> > > Date: Wed Jun 17 10:28:27 2015 -0500 > > > > netfilter: don't pull include/linux/netfilter.h from netns headers > > > > The issue is that definitions in linux/in.h overlap with those > > in netinet/in.h. This patch solves this by introducing the same > > mechanism as was used to solve the same problem with linux/in6.h > > My patch also modifies non-exposed net/netns/ headers, I'm not sure > how this can be causing problems to uapi headers. The problem is that your patch changes include/uapi/linux/netfilter.h to include linux/in.h. Some programs have already include <netinet/in.h> (often through a complex chain of headers). If both headers are included it causes errors and warnings about duplicate definitions. My patch fixes that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
