On Fri, Jun 26, 2015 at 01:48:17PM +0300, Konstantin Khlebnikov wrote: > Hash value passed as argument into rhashtable_lookup_compare could be > computed using different hash table than rhashtable_lookup_compare sees. > > This patch passes key into rhashtable_lookup_compare() instead of hash and > compures hash value right in place using the same table as for lookup. > > Also it adds comment for rhashtable_hashfn and rhashtable_obj_hashfn: > user must prevent concurrent insert/remove otherwise returned hash value > could be invalid. > > Signed-off-by: Konstantin Khlebnikov <[email protected]> > Fixes: e341694e3eb5 ("netlink: Convert netlink_lookup() to use RCU protected > hash table") > Link: http://lkml.kernel.org/r/[email protected] > Cc: Stable <[email protected]> (v3.17 .. v3.19)
This could indeed explain Eric's problems with those kernels. Eric, can you rerun your test to see if this patch makes your problem go away on the pre-4.0 kernels? Thanks! -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
