On Thu, Jun 25, 2015 at 04:50:13PM +0300, [email protected] wrote: > From: Gilad Ben-Yossef <[email protected]> > > DSA master netdev promiscuity counter was not being properly > decremented on slave device open error path. > > Signed-off-by: Gilad Ben-Yossef <[email protected]> > CC: Gilad Ben-Yossef <[email protected]> > CC: David S. Miller <[email protected]> > CC: Florian Fainelli <[email protected]> > CC: Guenter Roeck <[email protected]> > CC: Andrew Lunn <[email protected]> > CC: Scott Feldman <[email protected]>
Hi Gilad Acked-by: Andrew Lunn <[email protected]> FYI: I grep'ed the whole kernel. This seems to be the only place 0 is passed to dev_set_promiscuity(), i.e. the same bug is not present anywhere else. Thanks Andrew > --- > net/dsa/slave.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 04ffad3..0917123 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -112,7 +112,7 @@ static int dsa_slave_open(struct net_device *dev) > > clear_promisc: > if (dev->flags & IFF_PROMISC) > - dev_set_promiscuity(master, 0); > + dev_set_promiscuity(master, -1); > clear_allmulti: > if (dev->flags & IFF_ALLMULTI) > dev_set_allmulti(master, -1); > -- > 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
