Hi Andrew, On Jun 19, 2015, at 11:05 AM, Andrew Lunn and...@lunn.ch wrote: >> Yes I do have debug too, but via sysfs (with eventually write access) for: >> GLOBAL1, GLOBAL2, cpu port registers, SerDes registers, PVIDs, and VTU. >> Not really standard though. > > We should really get an implementation into mainline. There is no > point us all implementing our own.
I couldn't agree more. It's important for development to have read/write access to the switch registers, bypassing the userspace tools. > You say your code is not really standard. Do you think it would get > rejected if it was submitted? The rules for debugfs are much more > relaxed, so what i have should be acceptable. Yes my code will definitely be rejected. I have a net/dsa/debug.c file that creates a debug directory under /sys/devices/platform/dsa.0/ with global1, global2, cpu_port, serdes, pvid, and vtu sysfs attributes. Read and write access to debugfs sounds better IMO. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe netdev" in
