Hi, Hajime Tazaki wrote: > > Hello Josh, Dave, > > my mobile ipv6 test on libos failed with this commit. > > This commit makes a destination option header handling (i.e., > ipprot->handler == ipv6_destopt_rcv) failed since > ipv6_destopt_rcv() seems to return a positive value to > indicate to goto resubmission label. > > I will look for more detail.
I think we should look into other protocol handlers as well... --yoshfuji > > -- Hajime > > At Mon, 08 Jun 2015 12:16:01 -0700 (PDT), > David Miller wrote: >> >> From: Josh Hunt <joh...@akamai.com> >> Date: Mon, 8 Jun 2015 12:00:59 -0400 >> >>> UDP encapsulation is broken on IPv6. This is because the logic to resubmit >>> the nexthdr is inverted, checking for a ret value > 0 instead of < 0. Also, >>> the resubmit label is in the wrong position since we already get the >>> nexthdr value when performing decapsulation. In addition the skb pull is no >>> longer necessary either. >>> >>> This changes the return value check to look for < 0, using it for the >>> nexthdr on the next iteration, and moves the resubmit label to the proper >>> location. >>> >>> With these changes the v6 code now matches what we do in the v4 ip input >>> code wrt resubmitting when decapsulating. >>> >>> Signed-off-by: Josh Hunt <joh...@akamai.com> >> >> Applied. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Hideaki Yoshifuji <hideaki.yoshif...@miraclelinux.com> Technical Division, MIRACLE LINUX CORPORATION -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
