From: David Malcolm <dmalc...@redhat.com>
Date: Tue, 2 Jun 2015 15:31:17 -0400
> This code in drivers/net/ethernet/dec/tulip/uli526x.c
> function "uli526x_timer":
>
> 1086 } else
> 1087 if ((tmp_cr12 & 0x3) && db->link_failed) {
> [...snip...]
> 1109 }
> 1110 else if(!(tmp_cr12 & 0x3) && db->link_failed)
> 1111 {
> [...snip...]
> 1117 }
> 1118 db->init=0;
>
> is misleadingly indented: the
> db->init=0
> is indented as if part of the else clause at line 1086, but it is
> independent of it (no braces before the "if" at line 1087).
>
> This patch fixes the indentation to reflect the actual meaning of the code,
> though is it actually meant to be part of the "else" clause? (I'm a
> compiler developer, not a kernel person). It also adds spaces around
> the assignment, to placate checkpatch.pl.
I think the code is arranged as intended and the indentation is just wrong.
Patch applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
