On 2015/06/02 14:24, David Miller wrote: > From: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> > Date: Tue, 02 Jun 2015 13:51:06 +0900 > >> On 2015/06/02 3:39, sfel...@gmail.com wrote: >>> From: Scott Feldman <sfel...@gmail.com> >>> >>> Remove support for legacy ndo ops >>> .ndo_vlan_rx_add_vid/.ndo_vlan_rx_kill_vid. Rocker will use >>> bridge_setlink/dellink exclusively for VLAN add/del operations. >>> >>> The legacy ops are needed if using 8021q driver module to setup VLANs on >>> the port. But an alternative exists in using bridge_setlink/delink to >>> setup VLANs, which doesn't depend on 8021q module. So rocker will switch >>> to the newer setlink/dellink ops. VLANs can added/delete from the port, >>> regardless if port is bridged or not, using the bridge commands: >>> >>> bridge vlan [add|del] vid VID dev DEV self >> >> Hi Scott, >> >> This doesn't look transparent with bridge. >> >> Before this patch, I was able to add vid in the same way as software bridge: >> >> ip link set DEV master br0 >> bridge vlan add vid VID dev DEV >> >> Now I need to add "self", which is different from software bridge... > > I'm already not liking the looks of this....
I thought one of purposes of implementing ndo_vlan_rx_add_vid() is to make "bridge vlan add (master)" for bridged-ports work like software bridges. Sorry if I misunderstood. Toshiaki Makita -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
