On Sun, May 31, 2015 at 11:09 PM Ben Hutchings <b...@decadent.org.uk> wrote: > > On Tue, 2015-05-05 at 18:48 +0300, Amir Vadai wrote: > > On Mon, Apr 27, 2015 at 2:22 PM, Amir Vadai <am...@mellanox.com> wrote: > > > From: Eyal Perry <eya...@mellanox.com> > > > > > > This ethtool patch adds support to set and get the current RSS hash > > > function for the device through through the new hfunc field in the > > > ethtool_rxfh struct. Kernel supported hash function names are queried > > > with ETHTOOL_GSTRINGS (value 0 is reserved and skipped). > > > > > > Although currently no device supports a combination of hash > > > functions/attributes, this ethtool implementation will support it. Both > > > in the > > > set and in the get. > > > The device driver declares the functions and/or attributes that it > > > supports, > > > and ethtool will show it correctly and enable the user to set those > > > combinations. > > > If a combination is not supported - the device driver will fail the > > > operation > > > and ethtool will print an error message. > > > > > > Signed-off-by: Eyal Perry <eya...@mellanox.com> > > > Signed-off-by: Amir Vadai <am...@mellanox.com> > > > --- > > > Changes from V1: > > > - Fixed some English mistakes > > > - Fixed the complicated way to write '= req_hfunc;'... > > > - Better support in combination of hash functions/attributes > > > > Ben Hi, > > > > Could you take a look at this patch? > > Didn't we agree that only one hash function should be selected at once? > Can you send a new version that implements that? Yeh, and actually I did send a V1 according to that approach, but Dave Miller has suggested [1] that we might add control attributes in combination to the hash function.
[1] - http://permalink.gmane.org/gmane.linux.network/360812 Amir > > Ben. > > -- > Ben Hutchings > Reality is just a crutch for people who can't handle science fiction. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
