From: Tom Herbert <t...@herbertland.com> Date: Wed, 13 May 2015 15:27:59 -0400
>> I'm sure there will be some performance improvements possible, and I >> hope you will look into making sure this new programmable classifier >> is as light weight as possible. ... > I still have concerns about making flow_dissector more complex like > this. This still seems like it should this programmable logic be done > in a separate function. We call flow_dissector at least once per > packet via skb_get_hash, it is in the critical path, and adding > several conditionals can only slow it down and provides no new value > to skb_get_hash. At the very least can we at least get some > performance numbers to show impact of this? The part of what I said to Jiri above is meant exactly to ensure that he handles this. If we need a specialized fast path for the skb_get_hash() code paths, so be it. But I'm not going to denouce his entire efforts for something that hasn't even been shown to be an issue yet. And if it is, I'm sure Jiri will work to address it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
