From: Sonic Zhang <sonic....@gmail.com> Date: Tue, 5 May 2015 15:55:53 +0800
> From: Sonic Zhang <sonic.zh...@analog.com> > > It is possible that poll_controller is called from netpoll.c with irq > already disabled. Unexpected interrupt may be triggered if always > enable irq before returning from poll_controller. > > Signed-off-by: Sonic Zhang <sonic.zh...@analog.com> Nope, this is wrong. If you don't use disable_irq(), the interrupt handler can run in parallel on another cpu and you definitely do not want that. There is nothing wrong with the interrupt triggering on the enable_irq() here. If that causes some problem, there is a bug in this driver. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html