On Thu, 2015-04-23 at 14:29 -0700, Mahesh Bandewar wrote:
> +static void ipvlan_multicast_enqueue(struct ipvl_port *port,
> + struct sk_buff *skb)
> +{
> + if (skb->protocol == htons(ETH_P_PAUSE))
> + return;
But what happens to this packet ? It seems leaked ?
> +
> + spin_lock(&port->backlog.lock);
> + if (skb_queue_len(&port->backlog) < IPVLAN_QBACKLOG_LIMIT) {
> + __skb_queue_tail(&port->backlog, skb);
> + spin_unlock(&port->backlog.lock);
> + } else {
> + spin_unlock(&port->backlog.lock);
> + atomic_long_inc(&skb->dev->rx_dropped);
> + kfree_skb(skb);
> + }
> + schedule_work(&port->wq);
No point calling schedule_work(&port->wq); if packet was dropped.
We are under pressure, so don't add extra cpu cycles ;)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
