There can be quite a lot of rx/tx drops message and affect useful message, so need to ratelimit them to not overwhelm logging.
Signed-off-by: Ding Tianhong <[email protected]> Cc: "David S. Miller" <[email protected]> Cc: Eric Dumazet <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Zhangfei Gao <[email protected]> Cc: Dan Carpenter <[email protected]> Cc: Joe Perches <[email protected]> --- drivers/net/ethernet/hisilicon/hip04_eth.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index a7ab1d9..b19830d 100644 --- a/drivers/net/ethernet/hisilicon/hip04_eth.c +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c @@ -608,11 +608,15 @@ static irqreturn_t hip04_mac_interrupt(int irq, void *dev_id) if (ists & (RCV_NOBUF | RCV_DROP)) { stats->rx_errors++; stats->rx_dropped++; - netdev_err(ndev, "rx drop\n"); + if (net_ratelimit()) + netdev_dbg(ndev, "rx drop: %lu\n", + stats->rx_dropped); } if (ists & TX_DROP) { stats->tx_dropped++; - netdev_err(ndev, "tx drop\n"); + if (net_ratelimit()) + netdev_dbg(ndev, "tx drop: %lu\n", + stats->rx_dropped); } } -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
