On Wed, 20 Feb 2008, Magnus Damm wrote: > This patch introduces struct smc91x_platdata and modifies the driver so > bus width is checked during run time using SMC_nBIT() instead of > SMC_CAN_USE_nBIT. > > Signed-off-by: Magnus Damm <[EMAIL PROTECTED]> > ---
NAK. The SMC91C111 (for example) is often used on devices which have a CPU clock barely higher than the network throughput, hence it is crutial for those devices to have the most efficient access possible to the chip or performance will suffer. This is the main reason behind the heavily macroized register access so things are always optimized for the data bus capabilities at compile time. This patch introduces a runtimes test on lp->cfg.flags for every register access even on those platforms not using the platform data based bus configuration at all. I think you should add a SMC_DYNAMIC_BUS_CONFIG and redefine SMC_nBITS() so they dereference cfg.flags only when it is defined. Nicolas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
