On 24-01-2008 22:51, Stephen Hemminger wrote: > Normally during a dump the key of the last dumped entry is used for > continuation, but since lock is dropped it might be lost. In that case > fallback to the old counter based N^2 behaviour. This means the dump will > end up > skipping some routes which matches what FIB_HASH does. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ... > @@ -1918,35 +1931,37 @@ static int fn_trie_dump(struct fib_table > struct leaf *l; > struct trie *t = (struct trie *) tb->tb_data; > t_key key = cb->args[2]; > + int count = cb->args[3]; > > rcu_read_lock();
Sorry, but I lost the point: is rtnl held or not held here at the moment? If held, how this rcu_read_lock can help? Maybe some additional comment in the code? Thanks, Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
