Jeff Garzik <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Hi, > > > > I have posted this patch in the past with absolutely no reply. > > I would appreciate some sort of feedback of the form interested/not > > interested. Should I just drop it? > > > > "ethtool -S" only supports devices that have custom code written to > > print the stats. > > No -- more specifically, ethtool is for NIC-specific statistics that > do not appear elsewhere. > > net_device_stats already appear elsewhere, so it's redundant to add it > to ethtool. Just duplicates the same functionality elsewhere.
Then please add to -S entry of the ethtool man page something like: "Only statistics for devices that do not use the generic stat infrastructure are printed". It is rather confusing for users that "ethtool -S" prints stats for some devices, and nothing for others, and the documentations says nothing about this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
