On 15-01-2008 07:36, Makito SHIOKAWA wrote:
...
> --- a/drivers/net/bonding/bond_sysfs.c
> +++ b/drivers/net/bonding/bond_sysfs.c
> @@ -643,10 +643,8 @@ static ssize_t bonding_store_arp_interva
>                      "%s Disabling MII monitoring.\n",
>                      bond->dev->name, bond->dev->name);
>               bond->params.miimon = 0;
> -             if (delayed_work_pending(&bond->mii_work)) {
> -                     cancel_delayed_work(&bond->mii_work);
> -                     flush_workqueue(bond->wq);
> -             }
> +             cancel_delayed_work(&bond->mii_work);
> +             flush_workqueue(bond->wq);

I wonder why don't you use cancel_delayed_work_sync() here (and in a
few other places), like in bond_work_cancel_all() from patch 2/4?

Regards,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to