On Fri, Jan 11, 2008 at 12:10:42AM +0100, Jarek Poplawski wrote: > > It seems this optimization could've a side effect: if during such a > loop updates are done, and r is seen !NULL during while() check, but > NULL after rcu_dereference(), the listing/counting could stop too > soon. So, IMHO, probably the first version of this patch is more > reliable. (Or alternatively additional check is needed before return.)
No, while the value of r->u.dst.rt_next can change between two readings, the value of r cannot. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
