From: "Rami Rosen" <[EMAIL PROTECTED]> Date: Fri, 28 Dec 2007 17:56:46 +0200
> It seems to me that neigh_is_valid() inline method from > include/net/neighbour.h can be removed since it is not used. > > Though it can be considered as an API for future use, and > indeed we have neigh_is_connected() method in this same header (which is BTW > used only in one place, drivers/net/cxgb3/l2t.c), we can easily notice > that we don't have > any accessor method to check whether the neighbour is in NUD_IN_TIMER > (not to mention that we don't have methods to check the single neighbour > states, > like NUD_REACHABLE or NUD_DELAY or the other ones). So for consistency > I suggest to > consider removing the neigh_is_valid() method. > > Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> This is a helper function which was used by drivers implementing support for the old fast routing code which we removed years ago. So yes we should remove this. Patch applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
