From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Sat, 29 Dec 2007 01:41:23 +0100 (CET)
> > On Dec 29 2007 02:09, Adrian Bunk wrote: > >On Sat, Dec 29, 2007 at 12:45:12AM +0100, Jan Engelhardt wrote: > >> Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate > >> so they can be built as modules. This will allow CONFIG_LLC to be > >> built as a module too, overall reducing the core kernel image size. > >>... > > > >Just an example of code you have to fix if you do this: > > > >$ grep -r "#ifdef CONFIG_TR" net/ > > Ah, thank you for reminding me. For lec.c, would it be ok to do > > #if defined(CONFIG_TR) || defined(CONFIG_TR_MODULE) > # define WITH_TR 1 > #endif We don't have a WITH_IPV6, we open code the ifdef check all over the tree. For consistency you should do that here too. Please don't add new ad-hoc macros to deal with situations like this. If it's really a problem it should be handled globally in the confines of the config system, not on a case-by-case basis. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
