On Fri, 21 Dec 2007, Bill Fink wrote: > On Fri, 21 Dec 2007, Bill Fink wrote: > > > Or perhaps even: > > > > /* Ok, it looks like it is advisable to defer. */ > > tp->tso_deferred = jiffies; > > > > /* need to return a non-zero value to defer, which means won't > > * defer if jiffies == 0 but it's only a 1 in 4 billion event > > * (and avoids a compare/branch by not checking jiffies) > > / > > return jiffies; > > Ack. I introduced my own 64-bit to 32-bit issue (too late at night). > How about: > > /* Ok, it looks like it is advisable to defer. */ > tp->tso_deferred = jiffies; > > /* this won't defer if jiffies == 0 but it's only a 1 in > * 4 billion event (and avoids a branch) > */ > return (jiffies != 0);
I'm not sure how the jiffies work but is this racy as well? Simple return tp->tso_deferred; should work, shouldn't it? :-) -- i. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
