On Fri, 21 Dec 2007 22:58:04 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote:
> In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 22:49:59 +0900), "Satoru
> SATOH" <[EMAIL PROTECTED]> says:
>
> > I agree.
> >
> > I mistakenly thought hz in that context must be larger than 1000..
> > As it's uncertain, your's looks much simpler and better.
> >
> > (btw, the lines "else .... div = 1" is not needed, is it?)
>
> Simplest fix is as follows:
>
> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
> --
> diff --git a/ip/iproute.c b/ip/iproute.c
> index f4200ae..7a885b0 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -509,7 +509,7 @@ int print_route(const struct sockaddr_nl *who, struct
> nlmsghdr *n, void *arg)
> i != RTAX_RTO_MIN)
> fprintf(fp, " %u",
> *(unsigned*)RTA_DATA(mxrta[i]));
> else {
> - unsigned val = *(unsigned*)RTA_DATA(mxrta[i]);
> + unsigned long long val =
> *(unsigned*)RTA_DATA(mxrta[i]);
>
> val *= 1000;
> if (i == RTAX_RTT)
> @@ -517,7 +517,7 @@ int print_route(const struct sockaddr_nl *who, struct
> nlmsghdr *n, void *arg)
> else if (i == RTAX_RTTVAR)
> val /= 4;
> if (val >= hz)
> - fprintf(fp, " %ums", val/hz);
> + fprintf(fp, " %llums", val/hz);
> else
> fprintf(fp, " %.2fms", (float)val/hz);
> }
>
applied thanks.
--
Stephen Hemminger <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
