From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 11:40:51 +0100
> On Fri, 21 Dec 2007 01:55:43 -0800 (PST) > David Miller <[EMAIL PROTECTED]> wrote: > > Please tell me if you are OK with this solution, or if you prefer > I change sk_forward_alloc to be unsigned :) When I was playing with this crap a long time ago I think I remember that sk->sk_forward_alloc can become negative in some circumstances. Or maybe that was just a bug :-) > Here is the patch handling the change on sk_wmem_queued, sk_sndbuf. > Keeping small patches may help future bisection anyway... > > [SOCK] Avoid integer divides where not necessary in include/net/sock.h > > Because sk_wmem_queued, sk_sndbuf are signed, a divide per two > may force compiler to use an integer divide. > > We can instead use a right shift. > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> I'll apply this, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
