From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:50:37 +0300
> The neigh_del_timer() looks sane - it removes the timer and > (conditionally) puts the neighbor. I expected, that the > neigh_add_timer() is symmetrical to the del one - i.e. it > holds the neighbor and arms the timer - but it turned out > that it was not so. > > I think, that making them look symmetrical makes the code > more readable. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> I agree, it looks more reable now, applied. This code used to be a lot worse, I think we had some confusion about whether the timer should always not be pending in these circumstances. But that was a bug fix from a long time ago, however I believe that's where the dump_stack() bug check came from in the add timer case. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
