On Dec 20, 2007 12:05 PM, Kok, Auke <[EMAIL PROTECTED]> wrote: > > I can't even apply this patch and the e1000 one... not only is it whitespace > damaged it is also not properly formatted as patch at all. If you want me to > take > these patches seriously, then please fix the formatting issues.
Sigh - I use Pine, follow Documents/email-clients.txt for the recommended settings and obviously the pathces are not generated with whitespace damage at my end as I test those before sending out. So although I hate to see this happen there is nothing at this moment that I can do - except for attaching the patch instead of inlining it. Since they have already been reviewed inline, please see if the attached patches work for you. [EMAIL PROTECTED] linux-2.6]$ scripts/checkpatch.pl --no-tree ../../Patches/e1000_main.c.patch total: 0 errors, 0 warnings, 8 lines checked Your patch has no obvious style problems and is ready for submission. [EMAIL PROTECTED] linux-2.6]$ [EMAIL PROTECTED] linux-2.6]$ vim drivers/net/e1000/e1000_main.c [EMAIL PROTECTED] linux-2.6]$ patch -p1 < ../../Patches/e1000_main.c.patch patching file drivers/net/e1000/e1000_main.c [EMAIL PROTECTED] linux-2.6]$ scripts/checkpatch.pl --no-tree ../../Patches/e1000e-netdev.c.patch total: 0 errors, 0 warnings, 8 lines checked Your patch has no obvious style problems and is ready for submission. [EMAIL PROTECTED] linux-2.6]$ patch -p1 < ../../Patches/e1000e-netdev.c.patch patching file drivers/net/e1000e/netdev.c Thanks Parag
e1000_main.c.patch
Description: Binary data
e1000e-netdev.c.patch
Description: Binary data
