Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

[Christoph Hellwig]

On Tue, Dec 11, 2007 at 01:50:39PM +0200, Ilpo J?rvinen wrote:
> +             BUG_ON((prev != NULL) && !tcp_skb_adjacent(sk, prev, 
> skb[queue]));
> +
> +             tcp_for_write_queue_from(skb[queue], sk, queue) {
> +                     if ((prev != NULL) && !tcp_skb_adjacent(sk, prev, 
> skb[queue]))
> +                             break;
> +
> +                     if (!before(TCP_SKB_CB(skb[queue])->seq, 
> tcp_sk(sk)->snd_nxt) ||
> +                         TCP_SKB_CB(skb[queue])->fack_count == fc)
> +                             return;

There's quite a few overflows of the normal 80 char limit here.  Because
you're current style is a little on the verbose side that's trivially
fixable, though:

                BUG_ON(prev && !tcp_skb_adjacent(sk, prev, skb[queue]));

                tcp_for_write_queue_from(skb[queue], sk, queue) {
                        if (prev && !tcp_skb_adjacent(sk, prev, skb[queue]))
                                break;

                        if (!before(TCP_SKB_CB(skb[queue])->seq,
                                               tcp_sk(sk)->snd_nxt) ||
                            TCP_SKB_CB(skb[queue])->fack_count == fc)
                                return;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html