Jarek Poplawski írta:
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
In do_setlink() a single ntification is sent at the end of the function
if any modification occured. If the address has been changed, another
notification is sent.
...
@@ -858,6 +859,7 @@ static int do_setlink(struct net_device *dev, struct
ifinfomsg *ifm,
if (tb[IFLA_BROADCAST]) {
nla_memcpy(dev->broadcast, tb[IFLA_BROADCAST], dev->addr_len);
send_addr_notify = 1;
+ modified = 1;
}
..
if (send_addr_notify)
call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
+
+ if (modified)
+ netdev_state_change(dev);
+
The subject suggests there might be less notifications. The patch actually
adds a little. Any additional comment why they are necessary?
The actual state of a device contains its address(es), also address
change implies state change, but these are different netlink messages
also the NETDEV_CHANGEADDR cannot be dropped because the other one is used.
Attila
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
