On Fri, Nov 30, 2007 at 08:29:16PM +0300, Pavel Emelyanov wrote: > Since the path is modified, it is put on the stack, to avoid > possible races with multiple calls to neigh_sysctl_register() : it > is called by protocols and I didn't find any protection in this > case. Did I overlooked the rtnl lock?.
I think the only caller that can be a module is IPv6 :) > The stack growth of the neigh_sysctl_register() is 40 bytes. I > believe this is OK, since this is not that much and this function > is not called with the deep stack (device/protocols register). Yes it's fine. > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Both applied to net-2.6.25. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
