On Tue, Nov 20, 2007 at 04:35:09PM +0300, Evgeniy Polyakov wrote: > > On Tue, Nov 20, 2007 at 08:27:05AM -0500, Andrew Gallatin ([EMAIL PROTECTED]) > wrote: > > Hmm.. rather than a global tunable, what if it was a > > network driver managed tunable which toggled a flag in the > > lro_mgr features? Would that be better? > > What about ethtool control to set LRO_simple and LRO_ACK_aggregation?
I have two concerns about this: 1) That same option can still be turned on by distros. 2) This doesn't make sense because the code is actually in the core networking stack. I'm particular unhappy about 2) because I don't want be in a situation down the track where every driver is going to add this option so that they're not left behind in the arms race. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
