From: David Stevens <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 08:53:13 -0800

> Maybe I'm more used to hex, but I personally don't think those are
> more readable. It replaces 1-line macroes with 4-line functions, and
> I think more vgrepping to pick out the relevant constant data.

Yes, the readability is agruable but I like the type checking.

I would also change the names, it's a better idea to prefix the
names with a namespace for the stuff being operated on, therefore
I'd prefer names like "ipv4_is_loopback()" etc.

I'm dropping these patches for now.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to