> > You could optimize this by getting HARD_TX_LOCK after the check. I > > assume that netif_stop_subqueue (from another CPU) would always be > > called by the driver xmit, and that is not possible since we hold > > the __LINK_STATE_QDISC_RUNNING bit. Does that sound correct? > > I don't think this is a critical optimization at this time, > but something to certainly do along with the surgery > we'll undoubtedly be doing here in the future :-)
Apologies for the spam... I guess this check can be completely removed once other qdiscs are modified to support subqueue. Essentially sch_prio and sch_rr executes subqueue_stopped twice for every skb while this check is required only for other qdiscs (and really belongs in the individual qdisc dequeue handlers). Thanks, - KK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
