From: PJ Waskiewicz <[EMAIL PROTECTED]> Date: Tue, 13 Nov 2007 09:44:50 -0800
> The only qdiscs that check subqueue state before dequeue'ing are PRIO > and RR. The other qdiscs, including the default pfifo_fast qdisc, will > allow traffic bound for subqueue 0 through to hard_start_xmit. The check > for netif_queue_stopped() is done above in pkt_sched.h, so it is > unnecessary for qdisc_restart(). However, if the underlying driver is > multiqueue capable, and only sets queue states on subqueues, this will > allow packets to enter the driver when it's currently unable to process > packets, resulting in expensive requeues and driver entries. This patch > re-adds the check for the subqueue status before calling hard_start_xmit, > so we can try and avoid the driver entry when the queues are stopped. > > Signed-off-by: Peter P Waskiewicz Jr <[EMAIL PROTECTED]> Applied, and I'll queue up the other one for -stable, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
